Xpra: Ticket #463: handle rgb modes without PIL

With older versions, we were grabbing the pixels using gdk pixbuf and it was doing the conversion to RGB(A) for us.

Now that we have XShm, we get pixel data in BGRA format (on small endian systems) and we therefore need to do the byteswapping ourselves (as clients expect RGB 24-bit or RGBA 32-bit). The code works fine using PIL, but since we don't require PIL as a hard dependency, the server should still work when it is missing.

The patch attached tries to do that:

forces PIL off (easier to test)
uses the argb module for the byteswapping
changes the argb module to access one int rather than one long at a time since we deal with 32-bit pixels

But doesn't seem to work...

Tue, 26 Nov 2013 15:49:15 GMT - Antoine Martin: attachment set

attachment set to rgb-no-PIL.patch

try to convert to RGB without PIL

Wed, 27 Nov 2013 13:47:23 GMT - Antoine Martin: status changed; resolution set

status changed from new to closed

resolution set to fixed

Done:

r4805 adds more byteswapping functions to the argb module and avoids reading with longs, which may read past the end of the buffer! (should be backported)

r4806 uses the argb module as fallback for PIL

r4807 + r4808 ensures the client tells the server which RGB modes are supported for the window: RGBA if we have transparency support, RGB otherwise (should be backported)

Sun, 01 Dec 2013 12:48:12 GMT - Antoine Martin:

Partial backport to v0.10.x in r4823

Sat, 23 Jan 2021 04:56:19 GMT - migration script: