#524 closed defect (invalid)
libav10 compatibility FTBFS
| Reported by: | onlyjob | Owned by: | Antoine Martin |
|---|---|---|---|
| Priority: | major | Milestone: | 0.12 |
| Component: | core | Version: | 0.11.x |
| Keywords: | Cc: |
Description
As reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=739459
some changes are to be made for libav10 compatibility.
Migration documentation can be found at
https://wiki.libav.org/Migration/10
Please review the attached patch that fixes build-time errors. It is not tested at run-time yet.
Attachments (1)
Change History (6)
Changed 7 years ago by
| Attachment: | libav10.patch added |
|---|
comment:2 Changed 7 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
We already use those constants for ffmpeg v2 onwards in dec_avcodec2, see here: xpra.codecs.dec_avcodec2.decoder. Unfortunately, last time I checked it built OK but did not work properly with libav (runtime crashes).
This patch would break dec_avcodec builds for many distributions, including from a quick grep:
- Ubuntu Precise
- Ubuntu Quantal
- Ubuntu Saucy
- Debian Wheezy
Whilst only improving the situation on:
- Debian Jessie
- Debian Sid
- Ubuntu Trusty
So I am closing this as invalid, and will apply the patch at build time only.
FYI: dec_avcodec is in maintenance mode, and new work is only added to dec_avcodec2 (h265 support, etc..)
comment:3 Changed 7 years ago by
FYI: here are some better patches:
- new-libav-new_codec_ids.patch (far less intrusive than the patch above)
- new-libav-no0RGB.patch (required for building, the patch above was clearly never even compile tested)
Note: for every release, I waste a few hours dealing with libav patching. Tiresome.
That burden is multiplied by the number of projects that link against it. Mind boggling.
comment:5 Changed 6 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/524
copyleft 2010 - 2021
proposed patch