Xpra: Ticket #524: libav10 compatibility FTBFS

As reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=739459 some changes are to be made for libav10 compatibility.

Migration documentation can be found at https://wiki.libav.org/Migration/10

Please review the attached patch that fixes build-time errors. It is not tested at run-time yet.

Mon, 03 Mar 2014 02:56:22 GMT - onlyjob: attachment set

attachment set to libav10.patch

proposed patch

Mon, 03 Mar 2014 03:20:09 GMT - onlyjob:

Tested with libav9 -- all good. Builds fine and works well.

Mon, 03 Mar 2014 03:44:36 GMT - Antoine Martin: status changed; resolution set

status changed from new to closed
resolution set to invalid

We already use those constants for ffmpeg v2 onwards in dec_avcodec2, see here: xpra.codecs.dec_avcodec2.decoder. Unfortunately, last time I checked it built OK but did not work properly with libav (runtime crashes).

This patch would break dec_avcodec builds for many distributions, including from a quick grep:

Ubuntu Precise
Ubuntu Quantal
Ubuntu Saucy
Debian Wheezy

Whilst only improving the situation on:

Debian Jessie
Debian Sid
Ubuntu Trusty

So I am closing this as invalid, and will apply the patch at build time only.

FYI: dec_avcodec is in maintenance mode, and new work is only added to dec_avcodec2 (h265 support, etc..)

Mon, 03 Mar 2014 04:27:56 GMT - Antoine Martin:

FYI: here are some better patches:

new-libav-new_codec_ids.patch (far less intrusive than the patch above)
new-libav-no0RGB.patch (required for building, the patch above was clearly never even compile tested)

Note: for every release, I waste a few hours dealing with libav patching. Tiresome.

That burden is multiplied by the number of projects that link against it. Mind boggling.

Sun, 23 Mar 2014 15:35:22 GMT - Antoine Martin: milestone changed

milestone changed from 0.13 to 0.12

re-assigning to correct milestone

Sat, 23 Jan 2021 04:58:20 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/524