Context Navigation

← Previous Ticket
Next Ticket →

#536 closed defect (fixed)

tray error

Reported by:	onlyjob	Owned by:	onlyjob
Priority:	critical	Milestone:
Component:	core	Version:	0.11.x
Keywords:		Cc:

Description

In just released 0.11.5 tray is no longer working -- when I click xpra icon in tray or any application icons the following is printed by the client:

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/xpra/client/gtk_base/statusicon_tray.py", line 49, in activate_menu
    self.may_guess()
  File "/usr/lib/python2.7/dist-packages/xpra/client/gtk_base/statusicon_tray.py", line 41, in may_guess
    log("may_guess() GUESS_GEOMETRY=%s, current guess=%s", GUESS_GEOMETRY, self.geometry_guess)
NameError: global name 'log' is not defined

Change History (8)

comment:1 Changed 7 years ago by onlyjob

Component:	android → core
Priority:	major → critical
Version:	→ v0.11.x

comment:2 Changed 7 years ago by Antoine Martin

Damn, bad backport in r5833, fixed in r5840.

Will release 0.11.6 with this one.

comment:3 Changed 7 years ago by Antoine Martin

Owner:	changed from Antoine Martin to onlyjob

Does this fix things for you? (I am the process of releasing 0.11.6 - don't want to miss something again as this costs me about ~2 hours)

comment:4 Changed 7 years ago by onlyjob

I know the feeling... It often cost me hours to test.

From the brief look r5840 seems all right. I will test 0.11.6 thoroughly when released.

Thanks for your hard work.

comment:5 Changed 7 years ago by onlyjob

I mean I tried r5840, it works, this problem with tray is fixed.

comment:6 Changed 7 years ago by onlyjob

By the way I'm getting some seemingly harmless warnings from client:

FIXME: Ignoring ClientMessage type=_NET_STARTUP_INFO_BEGIN with format=8 (!=32)
FIXME: Ignoring ClientMessage type=_NET_STARTUP_INFO with format=8 (!=32)

Are they safe to ignore?

comment:7 Changed 7 years ago by Antoine Martin

Resolution:	→ fixed
Status:	new → closed

Thanks, I've pushed 0.11.6 with this fix only.

The _NET_STARTUP_INFO* stuff is part of the startup notification protocol. They are totally safe to ignore (we have nothing to do with them) and r5843 silences this warning (will queue it for 0.11.7)