Xpra: Ticket #552: 0.12.1: switching to RGB encoding from tray do not work

With 0.12.1 RGB encoding does not work any more. First I've noticed it when I've chosen PNG/greyscsale, then switched to RGB and noticed that windows remained colourless. Then I tried to attach with "--encoding=raw" and got error "invalid encoding: raw".



Fri, 28 Mar 2014 00:40:49 GMT - Antoine Martin: owner changed

There has never been a raw encoding, my guess is that you probably want rgb.

See:

man xpra

or:

xpra attach --encoding=help


I've chosen PNG/greyscsale, then switched to RAW and noticed that windows remained colourless


Now that would be a bug. Did you switch from the tray? Does it work if you switch from the command line?


Fri, 28 Mar 2014 01:24:43 GMT - onlyjob:

Yes switching to rgb do not work from tray. Very easy to reproduce.

Obviously I forgotten encoding name (sorry). I tried again with --encoding=rgb and it worked on attach. I know how to *choose* encoding with --encoding given on attach but I don't know how to *switch* encoding from command line for active session (is it even possible?).


Fri, 28 Mar 2014 02:32:51 GMT - onlyjob: summary changed


Fri, 28 Mar 2014 04:10:12 GMT - Antoine Martin: priority, description changed

Fixed in r5930, backport to v0.12.x branch in r5931.

That was caused by the fact that "rgb" is a pseudo encoding, encompassing both "rgb24" (for regular pixels) and "rgb32" for transparent windows. The validation was too strict.

I am lowering the priority of this ticket (and not rushing a new stable release) as all the other encodings work as expected and a workaround exists (use the command line rather than the tray).


I don't know how to *switch* encoding from command line for active session


That was a surprising omission from the "xpra control" interface, rectified in r5934:

xpra control :10 encoding rgb


Can I close this ticket?


Fri, 28 Mar 2014 04:59:36 GMT - onlyjob:

Replying to totaam:

Fixed in r5930, backport to v0.12.x branch in r5931.

I'm unable to confirm that r5931 fixes it -- I applied it to 0.12.1 but the problem is still there...

I am lowering the priority of this ticket (and not rushing a new stable release) as all the other encodings work as expected and a workaround exists (use the command line rather than the tray).

Agreed.

I don't know how to *switch* encoding from command line for active session


That was a surprising omission from the "xpra control" interface, rectified in r5934:

xpra control :10 encoding rgb

Cool! :)

Can I close this ticket?

Let's make sure it fixed please. I'll test within hours so I hope it won't take long. Thanks.


Mon, 31 Mar 2014 02:18:07 GMT - onlyjob: status changed; resolution set

Fixed in 0.12.2, thanks.


Sat, 23 Jan 2021 04:59:08 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/552