Xpra: Ticket #575: miss build/check of build.version and version attribute in hello message
the variable is ill-formed within several point in code, I attached patch that resolve the issue.
the patch is on top of trunk @ 6539
Thu, 22 May 2014 22:57:21 GMT - Benoit Gschwind: attachment set
set to 0001-fix-error-in-hello-message-linked-to-build.version-a.patch
patch that resolve the issue
Fri, 23 May 2014 03:26:35 GMT - Antoine Martin: owner, description changed; milestone set
changed from Antoine Martin to Benoit Gschwind
set to 0.13
Thanks for the fix!
- merged the "mk" part in r6540, this makes perfect sense.
- I've also removed the version info duplication (twice!) in r6541, instead of fixing the prefix in one of the redundant calls.
- merged the code that looks for both the prefixed version (
proxy.build.version) and the "legacy" one (
proxy.version) in r6542. (that way, hopefully one day far into the future, we can drop the unprefixed one)
- r6543 also re-adds
proxy.version to the proxy's hello packet to remain backwards compatible with older clients
I believe this should now be OK and backwards compatible both ways?
Fri, 23 May 2014 11:00:41 GMT - Benoit Gschwind:
Seems working here :)
Fri, 23 May 2014 11:33:45 GMT - Antoine Martin: status changed; resolution set
changed from new to closed
set to fixed
Thanks! Bug squashed.
Sat, 28 Nov 2015 09:56:37 GMT - Antoine Martin: description changed
Sat, 23 Jan 2021 04:59:49 GMT - migration script:
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/575