xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 7 years ago

Closed 7 years ago

Last modified 5 months ago

#583 closed defect (fixed)

setup.py --user doesn't install etc/xpra/xpra.conf and etc/xpra/xorg.conf properly

Reported by: Benoit Gschwind Owned by: Antoine Martin
Priority: trivial Milestone: 0.14
Component: core Version: trunk
Keywords: Cc:

Description

./setup.py install --user

does not install etc/xpra/xpra.conf and etc/xpra/xorg.conf properly

I attached a patch that solve the issue at less in my case, it install those files in $HOME/.local/etc/xpra, may break other option ?

Attachments (2)

0001-custum-setup-file.patch (685 bytes) - added by Benoit Gschwind 7 years ago.
0001-fix-user-installation.patch (787 bytes) - added by Benoit Gschwind 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by Benoit Gschwind

comment:1 Changed 7 years ago by Antoine Martin

Owner: changed from Antoine Martin to Benoit Gschwind

This patch would break "regular" global installation for all users.

What we need instead is a way of detecting when we're not installing globally, and use a relative path in that case (or just drop installing etc bits altogether in that case since they won't be picked up anyhow).

Simply checking for --user in sys.argv might be enough, though there might be other flags that are relevant.

Changed 7 years ago by Benoit Gschwind

comment:2 Changed 7 years ago by Benoit Gschwind

Owner: changed from Benoit Gschwind to Antoine Martin

Proposal for a proper patch

comment:3 Changed 7 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Applied in r6631. Thanks.

comment:4 Changed 7 years ago by Antoine Martin

Taken this ticket into account in r6895

comment:5 Changed 5 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/583

Note: See TracTickets for help on using tickets.