Xpra: Ticket #603: build_info.py missing when setup.py install is passed --skip-build

Build Procedure

$ python setup.py clean
$ python setup.py build
$ python setup.py install --prefix /usr --root /tmp/test --skip-build
$ ls /tmp/test/usr/lib64/python2.6/site-packages/xpra/build_info.py
ls: cannot access /tmp/test/usr/lib64/python2.6/site-packages/xpra/build_info.py: No such file or directory
$ python setup.py clean
$ python setup.py build
$ python setup.py install --prefix /usr --root /tmp/test
$ ls /tmp/test/usr/lib64/python2.6/site-packages/xpra/build_info.py
/tmp/test/usr/lib64/python2.6/site-packages/xpra/build_info.py

difference in file listings

$ diff /tmp/xpra-skip-build.txt /tmp/xpra.txt
15a16,17
> /tmp/test/usr/lib64/python2.6/site-packages/xpra/build_info.py
> /tmp/test/usr/lib64/python2.6/site-packages/xpra/build_info.pyc


Mon, 16 Jun 2014 08:54:17 GMT - Antoine Martin:

Maybe we can re-use the code from ticket:172#comment:37 for this.


Sat, 05 Jul 2014 14:34:38 GMT - pyther:

On lines 344 - 347 add_modules is being called

add_modules("xpra",
            "xpra.platform",
            "xpra.codecs",
            "xpra.codecs.xor")

add_module adds any *.py file that is in the xpra module directory. This includes things like xpra.src_info and xpra.build_info.

xpra/src_info.py and xpra/build_info.py don't get generated until lines 791-803. Therefore, when add_module(xpra) get called, the src_info.py and build_info.py don't exist, thus they don't get included.

I see two potential fixes:

I think solution 2 makes more sense, because the xpra code base tries to load values from these files and if they don't exist, errors get thrown.


Sun, 20 Jul 2014 17:49:42 GMT - Antoine Martin: owner changed

r6919 works for me, can you confirm?

(I should backport this to v0.13.x)


Tue, 29 Jul 2014 10:55:24 GMT - Antoine Martin: status changed; resolution set

Not heard back, closing. Shout if I'm wrong.


Sat, 23 Jan 2021 05:00:36 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/603