Xpra: Ticket #611: remove Xorg setuid detection in setup.py

Xorg setuid detection code is no longer necessary as this logic has been moved to scripts/xpra_Xdummy.

Additionally, if the user specifies --with-Xdummy, we shouldn't try to auto-detect Xorg settings.

Few notes about the patch:

xpra_Xdummy wrapper is always called for Xdummy support
if Xdummy is explicitly set (--with-Xdummy), don't autodetect
if Xdummy support is enabled, then has_displayfd is set to true.

Sat, 05 Jul 2014 02:16:48 GMT - pyther: attachment set

attachment set to xpra_setup_remove_xorg_setuid.patch

Sun, 06 Jul 2014 12:10:21 GMT - Antoine Martin: owner changed

owner changed from Antoine Martin to pyther

Why run a script when it isn't needed?

Some platforms (like Debian) always ship with an Xorg we can use directly, without needing any scripts. I don't want to force them to install and use a script that does absolutely nothing useful for them.

Sat, 12 Jul 2014 09:38:30 GMT - Antoine Martin:

I have applied most of the patch (and more) in r6889. But I will not apply the part that forces some distros (Debian and many future distros once Xorg becomes non-suid) to use a script they don't need.

Can I close this ticket? (will close as WONTFIX since the title is about suid detection, which will remain in place)

Tue, 29 Jul 2014 10:55:46 GMT - Antoine Martin: status changed; resolution set

status changed from new to closed
resolution set to wontfix

Not heard back, closing. Shout if I'm wrong.

Sat, 23 Jan 2021 05:00:50 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/611