#611 closed defect (wontfix)
remove Xorg setuid detection in setup.py
| Reported by: | pyther | Owned by: | pyther |
|---|---|---|---|
| Priority: | major | Milestone: | 0.14 |
| Component: | core | Version: | trunk |
| Keywords: | Cc: |
Description
Xorg setuid detection code is no longer necessary as this logic has been moved to scripts/xpra_Xdummy.
Additionally, if the user specifies --with-Xdummy, we shouldn't try to auto-detect Xorg settings.
Few notes about the patch:
- xpra_Xdummy wrapper is always called for Xdummy support
- if Xdummy is explicitly set (--with-Xdummy), don't autodetect
- if Xdummy support is enabled, then has_displayfd is set to true.
Attachments (1)
Change History (5)
Changed 7 years ago by
| Attachment: | xpra_setup_remove_xorg_setuid.patch added |
|---|
comment:1 Changed 7 years ago by
| Owner: | changed from Antoine Martin to pyther |
|---|
comment:2 Changed 7 years ago by
I have applied most of the patch (and more) in r6889.
But I will not apply the part that forces some distros (Debian and many future distros once Xorg becomes non-suid) to use a script they don't need.
Can I close this ticket? (will close as WONTFIX since the title is about suid detection, which will remain in place)
comment:3 Changed 7 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Not heard back, closing. Shout if I'm wrong.
comment:4 Changed 4 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/611
Note: See
TracTickets for help on using
tickets.
copyleft 2010 - 2021
Why run a script when it isn't needed?
Some platforms (like Debian) always ship with an Xorg we can use directly, without needing any scripts. I don't want to force them to install and use a script that does absolutely nothing useful for them.