#623 closed task (fixed)
consistent and reliable client exit code and information
Reported by: | Antoine Martin | Owned by: | Scott Bennett |
---|---|---|---|
Priority: | critical | Milestone: | 0.14 |
Component: | core | Version: | trunk |
Keywords: | Cc: |
Description
There can be many reasons why we close a connection.
Unless this is simply a network failure which is an error and should be reported as such (and the client process should terminate with a non-zero exit code), we should generally be able to tell the user why the disconnection occurred.
Most of the code is already there, it just needs to be constified so these values can be relied on.
Change History (7)
comment:1 Changed 8 years ago by
Owner: | changed from Antoine Martin to Scott Bennett |
---|
comment:2 Changed 8 years ago by
As of r7088, the server-side messages are nicer and the client tries to tell the server when it is exiting and why, ie:
- when receiving a control-C:
client Protocol(SocketConnection(/home/antoine/.xpra/desktop-10)) has requested disconnection: exit on signal SIGINT
- when exiting from the system tray:
client Protocol(SocketConnection(/home/antoine/.xpra/desktop-10)) has requested disconnection: client exit
comment:3 Changed 8 years ago by
Priority: | major → critical |
---|
Should be closed for v0.14.x, raising to critical.
comment:6 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Verified and tested in 0.14.12, thank you
comment:7 Changed 16 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/623
See r7075.
Please test, ie:
EXIT_OK
)xpra stop
) whilst the client is connected gives: server requested disconnect: server shutdown (and still 0)EXIT_CONNECTION_LOST
)EXIT_TIMEOUT
)Some of the other disconnection messages can be a bit harder to trigger, see #614 for example.
Will that do?