Xpra: Ticket #926: csc opencl performance has regressed

See wiki/CSC/Performance where I have added results for trunk. swscale has improved a lot since we last ran the tests, but the cython version has regressed.

Tue, 28 Jul 2015 06:52:57 GMT - Antoine Martin: owner changed

First problem is that you have to select the correct device... r10084 fixes that code, r10085 backports it.

Then after updating the wiki performance page above, it seems that the regression is not new: it happened between 0.14.x and 0.15.x (halved).

The other problem is our calls to memoryview_to_bytes (new related ticket: #927), which is a nice utility function, but too coarse: in some cases we can handle the data without converting it to bytes, and we should. r10087 + r10089 fix that for the opencl csc, backport in r10088 + r10090.

@smo: re-assigning to you so you can take a look at the performance data which might interest you, in particular just how fast swscale has become - but opencl isn't bad either...

Thu, 17 Sep 2015 17:56:25 GMT - Smo:

There has been many updates over this time period to Cython do you think this might be the regression we are seeing or is that totally unrelated?

Fri, 18 Sep 2015 04:57:21 GMT - Antoine Martin:

@smo: regression? csc_opencl is pure python...

And with the fixes above, the csc_opencl performance is as good as it was before.

Thu, 24 Sep 2015 22:03:03 GMT - Smo:

Sorry I misunderstood. Ignore my last comment.

I will run some more of these tests to make sure its still about the same as your tests.

Should I update that table with my test data as well?

Fri, 23 Oct 2015 06:28:26 GMT - Antoine Martin:

@smo: we should be recording as much data as we can, so that if a regression is introduced like the one above, we catch it before the release... not 2 releases later! (it wasn't too bad because we don't use csc_opencl, but a similar issue with csc_swscale would be costly!)

Mon, 11 Jan 2016 13:47:04 GMT - Antoine Martin: priority changed

Raising: see ticket:973#comment:2

Sun, 10 Apr 2016 06:13:04 GMT - Antoine Martin:

9 months... please just make some quick measurements and close.

Thu, 14 Apr 2016 18:10:54 GMT - Smo: status changed; resolution set

When I talked to you we agreed we weren't concerned with this module anymore as libyuv works very well.

Closing this for now without measurements. Will reopen if you find it absolutely necessary.

Sat, 23 Jan 2021 05:09:59 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/926