xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 6 years ago

Closed 6 years ago

Last modified 6 months ago

#958 closed enhancement (fixed)

windows installer add check to skip running

Reported by: Smo Owned by: Smo
Priority: minor Milestone: 0.16
Component: packaging Version: trunk
Keywords: Cc:

Description

Would like to check for environment variable DO_NOTRUN so we can skip running the installer at the end.

This is useful for automated build system.

Attachments (2)

install-notrun.patch (379 bytes) - added by Smo 6 years ago.
install-notrun-v2.patch (840 bytes) - added by Smo 6 years ago.

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by Smo

Attachment: install-notrun.patch added

comment:1 Changed 6 years ago by Smo

I'll set up the environment variable in the build system by doing

set DO_NOTRUN=1 before running MAKE-INSTALLER.BAT

comment:2 Changed 6 years ago by Antoine Martin

Owner: changed from Antoine Martin to Smo

I would prefer if you didn't GOTO END but instead enclosed the statement like this:

if "%DO_NOTRUN%"=="1" (
    %INSTALLER_FILENAME% %ARGS%
)

Then if things move around they still work as expected. (goto is often evil!)

If that works for you, feel free to commit and backport.

comment:3 Changed 6 years ago by Smo

Does this patch look better I've tested it works for me.

Changed 6 years ago by Smo

Attachment: install-notrun-v2.patch added

comment:4 Changed 6 years ago by Antoine Martin

Looks good, feel free to backport too.

comment:5 Changed 6 years ago by Smo

Added in r10390 and backported

I'll do one last test then close this.

comment:6 Changed 6 years ago by Smo

Resolution: fixed
Status: newclosed

Tested and working.

comment:7 Changed 6 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/958

Note: See TracTickets for help on using tickets.