Xpra: Ticket #958: windows installer add check to skip running

Would like to check for environment variable DO_NOTRUN so we can skip running the installer at the end.

This is useful for automated build system.

Fri, 21 Aug 2015 04:31:34 GMT - Smo: attachment set

Fri, 21 Aug 2015 04:32:44 GMT - Smo:

I'll set up the environment variable in the build system by doing

set DO_NOTRUN=1 before running MAKE-INSTALLER.BAT

Fri, 21 Aug 2015 04:37:20 GMT - Antoine Martin: owner changed

I would prefer if you didn't GOTO END but instead enclosed the statement like this:

if "%DO_NOTRUN%"=="1" (

Then if things move around they still work as expected. (goto is often evil!)

If that works for you, feel free to commit and backport.

Fri, 21 Aug 2015 06:09:13 GMT - Smo:

Does this patch look better I've tested it works for me.

Fri, 21 Aug 2015 06:09:40 GMT - Smo: attachment set

Fri, 21 Aug 2015 06:32:02 GMT - Antoine Martin:

Looks good, feel free to backport too.

Fri, 21 Aug 2015 06:40:32 GMT - Smo:

Added in r10390 and backported

I'll do one last test then close this.

Fri, 21 Aug 2015 07:30:08 GMT - Smo: status changed; resolution set

Tested and working.

Sat, 23 Jan 2021 05:10:53 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/958