#97 closed enhancement (fixed)
vpx encoding support
Reported by: | Antoine Martin | Owned by: | ahuillet |
---|---|---|---|
Priority: | minor | Milestone: | 0.2 |
Component: | core | Version: | 0.1.0 |
Keywords: | Cc: |
Description
the vpx api is almost identical to x264 so this is easy to add, the patch almost works but I must be doing something wrong with the packing/index of the channels
Attachments (1)
Change History (6)
Changed 10 years ago by
Attachment: | xpra-vpx.patch added |
---|
comment:1 Changed 10 years ago by
Owner: | changed from Antoine Martin to ahuillet |
---|---|
Status: | new → assigned |
please take a look, I am sure you can figure out what I did wrong quickly
note: when merging the x264 and vpx codepaths can be merged (in server.py and window_backing.py), only the implementation class is different (and the dimensions rounding - but this can also be moved to a codec class attribute).
comment:2 Changed 10 years ago by
- Your mask for window size is incorrect - should be FFFE to ensure even dimensions, FFFF just truncates it to < 65535.
- Are you sure that libvpx can do the RGB -> YUV420 colorspace conversion by itself? You're allocating an input picture in YUV420 format but filling it in with RGB packed data (hence a single plane)
- Same on the decompress side: the codec probably works with YUV420 (or any other form of YUV), but your output should be RGB
comment:3 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
- the mask is OK, vpx does not seem to mind odd dimensions, I left the mask code in to make it easier to merge the x264 and vpx code together
- rgb-yuv: yes, obviously.. that did the trick
r677 fixes the colourspace and vpx is now supported (also refactored the x264 code to re-use as much code as possible)
comment:4 Changed 10 years ago by
Milestone: | 0.1 → 0.2 |
---|
comment:5 Changed 16 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/97
Note: See
TracTickets for help on using
tickets.
vpx almost working