xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Changes between Initial Version and Version 1 of Ticket #970, comment 12


Ignore:
Timestamp:
10/28/15 16:35:48 (6 years ago)
Author:
Antoine Martin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #970, comment 12

    initial v1  
    2121But the dependency is hardcoded in the source... I even tried patching it out in the module to remove the video subfolder, which worked... but then I would have needed to rebuild all the other gstreamer modules too, so I gave up on that and we ship the 1.0 version of the video library.
    2222* noticed some {{{gst-plugin-scanner-1.0 -l}}} zombies left behind, which could be a problem. (can we just noop this thing instead? or have a wrapper that ensures it really does get killed as a last resort)
    23 * I was getting {{{** (<unknown>:602): CRITICAL **: gst_audio_ring_buffer_open_device: assertion 'GST_IS_AUDIO_RING_BUFFER (buf)' failed}}} on the machines I tested on, but not on the build machine... so something is missing? (and we should also detect that sound isn't working at this point) Copy things one at a time until it works would be hard (need to run name tool on each), so maybe just bundle everything and then remove one at a time instead... takes time. It would be worth running some basic sanity checks on this gstreamer installation first, is it even functional on the build machine?
    24 * last problem: the {{{GStreamer_info}}} command works... but when we run {{{XPRA_SKIP_UI=1 XPRA_GSTREAMER=1 ./Xpra.app/Contents/MacOS/Xpra _sound_query}}}, it fails to load {{{Gst}}}. (we need {{{XPRA_SKIP_UI=1}}} to avoid loading {{{gtkosx_application}}} which loads GTK2... which prevents the gi bindings from loading)... ideas welcome.
     23* I am getting {{{** (<unknown>:602): CRITICAL **: gst_audio_ring_buffer_open_device: assertion 'GST_IS_AUDIO_RING_BUFFER (buf)' failed}}} on the machines I tested on, but not on the build machine... so something is missing? (and we should also detect that sound isn't working at this point) Copy things one at a time until it works would be hard (need to run name tool on each), so maybe just bundle everything and then remove one at a time instead... takes time. It would be worth running some basic sanity checks on this gstreamer installation first, is it even functional on the build machine?
     24* {{{GStreamer_info}}} command was working but {{{XPRA_SKIP_UI=1 XPRA_GSTREAMER=1 ./Xpra.app/Contents/MacOS/Xpra _sound_query}}} was failing to load {{{Gst}}}. (we need {{{XPRA_SKIP_UI=1}}} to avoid loading {{{gtkosx_application}}} which loads GTK2... which prevents the gi bindings from loading)... fixed in r11077 by re-ordering imports.
    2525* we don't have mp3 or opus support - I haven't looked at why (flac is disabled and we know why)
    2626* if an when we decide to permanently switch to just one version of gstreamer, we can do that - but seeing the cost of those libraries compared to the overall size, I don't see the rush - having two versions is better for testing and debugging