Follow up from #901:
r12097 takes care of restoring the windows that were frozen during lock when the session is unlocked. Not mapping new windows is harder, so I am moving this one to #1138.
Ready for testing.
Tested with the r12103 Win8.1 Client:
-d win32
not showing anything interesting, at least to me. I'll attach a .txt with the logs captured from the client anyway, you may pick up on something I don't.
HOWEVER: Xpra does not crash; just the display driver.
Intel drivers...
Still, r12152 may help: we now wait before deiconifying the windows. The default delay is 1000 milliseconds, but you can change it with:
SET XPRA_DEICONIFY_DELAY=0 xpra_cmd attach ...
Let me know if any values help.
I would prefer if we found an event we can wait for instead of a delay (which may not work in all cases..), there may be one following the event we already use: WM_WTSSESSION_CHANGE: SESSION_UNLOCK on session 0x1
, but since you got a crash instead, maybe it never got a chance to be seen. Running again with a higher delay may show something we can use in the log output.
@antoine: Need new Windows Beta Builds
@maxmylyn: done!
FYI: there's another ticket for OSX which does something similar: #965.
Tried it a few times(half of Friday locking and unlocking, along with an hour this afternoon) with the r12161 client and it seems to be behaving for the time being. No more crashes or driver issues.
The default delay works fine. No real difference noticed when I set it to 0 or any other values (I tried 100,250,300,500
).
Passing back to you.
@maxmylyn: thanks for testing!
Since the zero-delay worked, I've changed the code in r12195 to make it better & cleaner, can you please re-test? (the XPRA_DEICONIFY_DELAY
no longer exists)
Somewhat related: ticket:540#comment:7
I retested this a couple weeks ago, and off and on since then and it is behaving pretty well. No more driver or Xpra crashes.
As of r12356 trunk client, it's still working. (Win81)
Passing back to you.
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/997